Defer timing animation start through JS Animated (#57003)#57003
Closed
zeyap wants to merge 2 commits into
Closed
Conversation
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106825746. |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 29, 2026
Summary: Wire `animatedDeferStartOfTimingAnimations` through the JS Animated layer: `AnimatedValue` arms a one-shot `__deferAnimationStart`, and `TimingAnimation` forwards `deferredStart` in the native animation config so the native `FrameAnimationDriver` defers its start to the first rendered frame. Gated behind the runtime flag (default off). Adds Fantom integration tests asserting the behavior with the flag on and off. ## Changelog: [Internal] [Changed] - Defer timing animation start through JS Animated Differential Revision: D106825746
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 29, 2026
Summary: Wire `animatedDeferStartOfTimingAnimations` through the JS Animated layer: `AnimatedValue` arms a one-shot `__deferAnimationStart`, and `TimingAnimation` forwards `deferredStart` in the native animation config so the native `FrameAnimationDriver` defers its start to the first rendered frame. Gated behind the runtime flag (default off). Adds Fantom integration tests asserting the behavior with the flag on and off. ## Changelog: [Internal] [Changed] - Defer timing animation start through JS Animated Differential Revision: D106825746
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
May 29, 2026
Summary: Wire `animatedDeferStartOfTimingAnimations` through the JS Animated layer: `AnimatedValue` arms a one-shot `__deferAnimationStart`, and `TimingAnimation` forwards `deferredStart` in the native animation config so the native `FrameAnimationDriver` defers its start to the first rendered frame. Gated behind the runtime flag (default off). Adds Fantom integration tests asserting the behavior with the flag on and off. ## Changelog: [Internal] [Changed] - Defer timing animation start through JS Animated Differential Revision: D106825746
Summary: Add the `animatedDeferStartOfTimingAnimations` common (native + JS) feature flag (default off). On its own this is a no-op; it gates deferring the start of native-driven timing animations to the first rendered frame, implemented in the following diffs. The flag is defined as a `common` flag (not JS-only) so the same value can be read from both the JS Animated layer and the native C++ animation code. This diff includes all the generated accessors, regenerated via `yarn featureflags --update`: Kotlin (`ReactNativeFeatureFlags*.kt`), C++ (`ReactNativeFeatureFlags*.h`/`.cpp` and the JNI interop), the JS `ReactNativeFeatureFlags.js`, and the native module spec. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D106825629
Summary: Wire `animatedDeferStartOfTimingAnimations` through the JS Animated layer: `AnimatedValue` arms a one-shot `__deferAnimationStart`, and `TimingAnimation` forwards `deferredStart` in the native animation config so the native `FrameAnimationDriver` defers its start to the first rendered frame. Gated behind the runtime flag (default off). Adds Fantom integration tests asserting the behavior with the flag on and off. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D106825746
|
This pull request has been merged in 1409118. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Wire
animatedDeferStartOfTimingAnimationsthrough the JS Animated layer:AnimatedValuearms a one-shot__deferAnimationStart, andTimingAnimationforwardsdeferredStartin the native animation config so the nativeFrameAnimationDriverdefers its start to the first rendered frame. Gated behind the runtime flag (default off). Adds Fantom integration tests asserting the behavior with the flag on and off.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D106825746